fix(container): container registry namespace is empty when not specified

garden-io / garden

Automation for Kubernetes development and testing. Spin up production-like environments for development, testing, and CI on demand. Use the same configuration and workflows at every step of the process. Speed up your builds and test runs via shared result caching

https://garden.io

Mozilla Public License 2.0

3.4k stars 275 forks source link

fix(container): container registry namespace is empty when not specified #6638

Closed twelvemo closed 2 weeks ago

twelvemo commented 2 weeks ago

What this PR does / why we need it: We defaulted a missing namespace spec in the deploymentRegistry config to _. However this will always lead to an invalid url in case deploymentRegistry.namespace is missing. I am not sure what the original thought behind this was, but omitting the namespace in case it is not specified by the user should be the way to go. Which issue(s) this PR fixes:

Fixes #6635

Special notes for your reviewer: