search

gardener / autoscaler

Customised fork of cluster-autoscaler to support machine-controller-manager
Apache License 2.0
16 stars 25 forks source link

Remove `snapshot_ctx_repository` attr from pipeline definition #276

Closed 8R0WNI3 closed 10 months ago

8R0WNI3 commented 11 months ago

This attribute will be removed with a future release of cc-utils. Hence, it must be removed from the pipeline definition as well. However, this will have no impact on the current functionality as the ocm_repository will be used as default for both "snapshot" and "non-snapshot" component descriptors.

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: The second occurrence of snapshot_ctx_repository is just removed and not replaced in this case, because the respective job has a release trait and thus the snapshot_ctx_repository was never used anyway.

Release note:

gardener-robot commented 11 months ago

@8R0WNI3 Thank you for your contribution.

gardener-robot commented 10 months ago

@unmarshall, @rishabh-11, @himanshu-kun You have pull request review open invite, please check

voelzmo commented 10 months ago

/lgtm thanks, @8R0WNI3!