search

gardener / autoscaler

Customised fork of cluster-autoscaler to support machine-controller-manager
Apache License 2.0
16 stars 25 forks source link

Cherry-pick of #309 #312

Closed rishabh-11 closed 4 months ago

rishabh-11 commented 4 months ago

What this PR does / why we need it: Cherry-pick of #309

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Fixed a bug where the instance status was nil when `machine.Status.LastOperation.Type` = `Create` causing it to not be considered as an unregistered Node and thereby cluster autoscaler never removing it
elankath commented 4 months ago

Possible to add a unit-test for generateInstanceStatus ?

rishabh-11 commented 4 months ago

Possible to add a unit-test for generateInstanceStatus ?

MCM manager, in general, has a very low unit testing. As we are looking into MCM-CA overhaul, we can do it later if required at all.