search

gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

Add additional logs in e2e tests #248

Closed dimitar-kostadinov closed 2 months ago

dimitar-kostadinov commented 2 months ago

How to categorize this PR?

/area testing /kind flake

What this PR does / why we need it: Add additional logs in e2e tests to identify root cause of flaky tests.

Pin GOLANGCI_LINT_VERSION to v1.60.3 to fix OOMKilled issue with golangci-lint v1.60.2 and go 1.23.0 ref: https://github.com/golangci/golangci-lint-action/issues/1094

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

NONE
gardener-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from dimitar-kostadinov. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dimitar-kostadinov commented 2 months ago

/test pull-gardener-extension-registry-cache-unit

gardener-prow[bot] commented 2 months ago

@dimitar-kostadinov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-registry-cache-e2e-kind d2913cad90e21f4cefcb2f55bf45d8f5f3c0ca89 link true /test pull-gardener-extension-registry-cache-e2e-kind

Full PR test history. Your PR dashboard. Command help for this repository. Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dimitar-kostadinov commented 2 months ago

/close

gardener-prow[bot] commented 2 months ago

@dimitar-kostadinov: Closed this PR.

In response to [this](https://github.com/gardener/gardener-extension-registry-cache/pull/248#issuecomment-2337948046): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.