Closed ialidzhikov closed 2 months ago
/hold
Maybe the same has to be applied for make remote-extension-down
. Let me check.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dimitar-kostadinov
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
How to categorize this PR?
/area dev-productivity /kind enhancement
What this PR does / why we need it: Locally, I hit the following issue. I executed
make extension-down
while I still had a Shoot with enabledregistry-cache
extension. The admission helm chart was deleted bymake extension down
which under the hood runsskaffold delete
. But the admission webhook was still present in the system (not part of the chart) and was blocking updates of the Shoot because there was no admission Pod running anymore. After https://github.com/gardener/gardener-extension-registry-cache/pull/122 the validating webhook is no longer part of the admission chart but it is created on admission Pod startup. Hence, we have to delete it explicitly.Which issue(s) this PR fixes: N/A
Special notes for your reviewer: N/A
Release note: