gardener / gardener-extension-registry-cache

Gardener extension controller which deploys pull-through caches for container registries.
Apache License 2.0
7 stars 20 forks source link

skaffold: Remove custom `tagPolicy` for the admission #294

Closed ialidzhikov closed 4 days ago

ialidzhikov commented 4 days ago

How to categorize this PR?

/area dev-productivity /kind cleanup

What this PR does / why we need it: In https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/pull/194#discussion_r1848606461 @plkokanov found that we don't need a custom tagPolicy for the admission.

Which issue(s) this PR fixes: Follow-up after https://github.com/gardener/gardener-extension-registry-cache/pull/279

Special notes for your reviewer: N/A

Release note:

NONE
gardener-prow[bot] commented 4 days ago

LGTM label has been added.

Git tree hash: 92634ba013a0aa87adbd82c4e2d2a9aba7838cd0

dimitar-kostadinov commented 4 days ago

Root pod creation failed:

  [FAILED] Unexpected error:
      <*errors.joinError | 0xc000150198>: 
      error sending request: Post "https://api.e2e-cache-pr.local.external.local.gardener.cloud/api/v1/namespaces/kube-system/pods/rootpod-865/exec?command=%2Fbin%2Fsh&container=root-container&stderr=true&stdin=true&stdout=true&tty=false": read tcp 172.18.255.1:47188->172.18.255.1:443: read: connection reset by peer
      {
          errs: [
              <*errors.errorString | 0xc00012c100>{
                  s: "error sending request: Post \"https://api.e2e-cache-pr.local.external.local.gardener.cloud/api/v1/namespaces/kube-system/pods/rootpod-865/exec?command=%2Fbin%2Fsh&container=root-container&stderr=true&stdin=true&stdout=true&tty=false\": read tcp 172.18.255.1:47188->172.18.255.1:443: read: connection reset by peer",
              },
          ],
      }
  occurred

/test pull-gardener-extension-registry-cache-e2e-kind

ialidzhikov commented 4 days ago

/approve

gardener-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/gardener/gardener-extension-registry-cache/blob/main/OWNERS)~~ [ialidzhikov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment