search

gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
257 stars 117 forks source link

Fix edge-case where scale-from-zero of MCD is mistaken for a rolling update #956

Closed thiyyakat closed 1 week ago

thiyyakat commented 1 week ago

What this PR does / why we need it:

The PR adds a check to distinguish between a rolling update and a scale-from-zero scenario. Additionally, it also updates the integration tests to verify MCM's behaviour for the scenario.

Which issue(s) this PR fixes: Fixes #952

Special notes for your reviewer: Integration tests with mcm-provider-gcp passed successfully.

Release note:

MCM recognizes scaling-up of `machineDeployment` from 0 to more replicas as a scaling event rather than a rolling update.
gardener-robot-ci-1 commented 1 week ago

Thank you @thiyyakat for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.