garimasingh128 / awesome-python-projects

📱 ✅ Some awesome projects in python! 📱 ✅

http://garimasingh.me/awesome-python-projects/

MIT License

1.04k stars 299 forks source link

Added titanic-solution #99

Closed thenorthkun closed 3 years ago

thenorthkun commented 3 years ago

Description

I have added a new ipynb notebook for Titanic survival project in which I have performed EDA on what sorts of people were likely to survive. Also used various ML algorithms to predict which passengers survived & displayed it in results/submissions. Please review @garimasingh128

Fixes #53 (Titanic Survival Project)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

garimasingh128 commented 3 years ago

Name it TITANIC_SURVIVAL_PROJECT
Add some screenshots in the same folder
Add some resource links in the README of the project.

thenorthkun commented 3 years ago

Should I put my screenshots in the 'Screenshot' folder ? and also I have to add resource links in the main README of the project folder, right ? @garimasingh128

garimasingh128 commented 3 years ago

Put screenshots in TITANIC_SURVIVAL_PROJECT folder and resource links in main readme.

thenorthkun commented 3 years ago

Changes made, please check if everything's in place @garimasingh128

garimasingh128 commented 3 years ago

Please name the folder to caps to TITANIC_SURVIVAL_PROJECT2. There's already a project with the same name so yours would overwrite it that's why the 2 at the end. Add the resource links to the main readme of the file. If you scroll to the bottom there you would see links to many projects, Add your reference links at the last.

thenorthkun commented 3 years ago

There you go @garimasingh128

thenorthkun commented 3 years ago

What's the problem now ? @garimasingh128

garimasingh128 commented 3 years ago

Conflicting files Titanic Survival Project/README.md

And change the folder name to TITANIC_SURVIVAL_PROJECT

thenorthkun commented 3 years ago

What's the issue with README.md file, I dont understand @garimasingh128

garimasingh128 commented 3 years ago

Can u change the folder name and delete the existing folder. I can resolve the README conflict after that. Or maybe create a fresh PR and close this one.

thenorthkun commented 3 years ago

okay so you mean delete that TITANIC_SURVIVAL_PROJECT2, and name it with the original one, I guess someone messed up that one

garimasingh128 commented 3 years ago

Nope that is fine. Just rename your Titanic Survival Project folder to TITANIC_SURVIVAL_PROJECT and create a new PR.

garimasingh128 commented 3 years ago

Please do this asap.

thenorthkun commented 3 years ago

I've had an health emergency in my family. Can you please give me time for just this week. I'll be back on Sunday

garimasingh128 commented 3 years ago

Ya sure. Please take your time. Family first.