garu / tweetylicious

a Twitter-like microblogging app in just one file
63 stars 18 forks source link

Fix for recent Mojolicious versions: run with 'app->start' instead of 'shagadelic' #7

Closed qualiabyte closed 13 years ago

qualiabyte commented 13 years ago

Hello!

I came across your tweetylicious app and found it to be a great introduction to using Mojolicious. It's amazing how much can be done with so little code.

There was only one problem: although the server would seem to initialize, requests to the index page (and others) triggered an infinite dispatch loop, burning cpu with no result.

After a while I realized that mojolicious has changed the way that apps are to be invoked: you just call 'app->start' instead of 'shagadelic'. Perhaps you know this by now as well...

Anyhow, this commit seems to fix those errors and makes the app a very usable demonstration once again (see commit message for a bit more info).

Hopefully this patch will help others using recent versions of mojo continue to get use from tweety.

All the best,

garu commented 13 years ago

Hi there!

Thanks for the nice words and the patch. This is actually a known issue with Mojolicious, fixed in 1.02 (https://github.com/kraih/mojo/commit/065b279001e92ba3b7468cf115e204ee467dfa0a). But since "app->start" is in fact a more straightforward way to, well, start the app, than "shagadelic", I'm accepting the patch anyway :-)

Cheers!