gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.
https://www.gatsbyjs.com
MIT License
55.3k stars 10.31k forks source link

Question about the "Adding Page Transitions with gatsby-plugin-page-transitions" stub #13620

Closed eclectic-coding closed 5 years ago

eclectic-coding commented 5 years ago

Summary

I have a question about the newly structured Stubs List. I understand the general idea about the stub-list and from an organizational perceptive it is a great idea.

My question is concerning the Stub for Adding Page Transitions with gatsby-plugin-page-transitions. It appears this page is already done, as the README is an incredible piece of documentation, and I am not sure it could be improved upon.

Are you looking for additional information or a different presentation for the Stub Page?

pieh commented 5 years ago

https://www.npmjs.com/package/gatsby-plugin-page-transitions is excellent plugin that abstracts lot of setup needed for page transitions, but it also is a bit opinionated (using react-transition-group). I think for the most part complete page would look something like this mention available packages for this:

And after that there could be advanced section - dive into how to setup custom page transition - for example like in this starter https://emilia.lekoarts.de/ / https://github.com/LekoArts/gatsby-starter-portfolio-emilia where transition was hand coded giving users most control over it (and not being limited by APIs provided by ready made packages)

gatsbot[bot] commented 5 years ago

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

gatsbot[bot] commented 5 years ago

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!