coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 386
- 62 of 67 (92.54%) changed or added relevant lines in 7 files are covered.
- 18 unchanged lines in 3 files lost coverage.
- Overall coverage increased (+2.6%) to 86.455%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/tortoise/connection/controller.ex | 6 | 7 | 85.71% | ||
| lib/tortoise/registry.ex | 5 | 6 | 83.33% | ||
| lib/tortoise/connection/inflight.ex | 14 | 17 | 82.35% | ||
| <!-- | Total: | 62 | 67 | 92.54% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| lib/tortoise/connection/receiver.ex | 1 | 84.38% | ||
| lib/tortoise/package/subscribe.ex | 1 | 80.0% | ||
| lib/tortoise/connection.ex | 16 | 80.47% | ||
| <!-- | Total: | 18 | --> |
| Totals | |
|---|---|
| Change from base Build 360: | 2.6% |
| Covered Lines: | 517 |
| Relevant Lines: | 598 |
Besides being a slight performance improvement this will provide us with a better interface, because we can quickly answer the question: does the connection on the given
client_ideven exist? Previously we would just respond with :ok publishes with QoS=0, or time out/hang if we send with QoS>0.