Closed kode54 closed 10 months ago
Oops, looks like the other modes also needed the exception fallback, because the base config model doesn't define the verbose flag.
Thank you, so this is not ready to merge yet?
@digitalsignalperson did you test the different gmi subcommands?
Oops admittedly I did not test sync with verbose mode, only push and pull. I'm only at the point of manually doing deliberate pushes and pulls and making sure I understand how everything changes on both sides (hence adding the verbose mode to help with this), so I haven't used the sync command ever yet! Sorry I guess I broke sync!
👍 Maybe we can find a way to do this in the unit tests eventually.
Hmm, I guess the intention is that gmi pull --verbose
and gmi sync --verbose
would both set self.verbose =
to True. Oh and I see that's what the PR does. Great!
The exception I added in the second commit will set self.verbose to False for all modes which do not have the verbose option defined in their option model. Unless it would be preferred to move the verbose option to the common model? Does it even affect any of the other operations?
I was experiencing the exception error on the gmi set
method as well, which was why I decided to add a generic catch-all.
It is better to add verbose to the common options than using exceptions for this.
I get this error on gmi init account
https://github.com/gauteh/lieer/issues/250 this should be updated to add the verbose option to the common namespace (and remove the specific ones).
Fixed through #252.
Fixes f7c3f594ee4a04c8289e8431df9d2e5470affc56 which broke sync: