gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.2k stars 484 forks source link

Visual SDF and Visual protobuf do not match #1440

Open osrf-migration opened 9 years ago

osrf-migration commented 9 years ago

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


A visual specified via SDF can have multiple plugins.

A visual specified via protobuf can only have one plugin.

We should change the protobuf message to have support multiple plugins. Make sure to update the VisualToSDF conversion function in msgs.cc

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


What if we deprecate the optional plugin field and replace it with a repeated plugins field? (see 1c9319f7383057411858609098140fb820d3ca0c in branch issue_1440)

osrf-migration commented 9 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


That looks good.

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Ok, we just need to change the logic to use the new fields and give an warning message if the old field is used.

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Also, the model.proto is missing the allow_auto_disable field that is included in model.sdf. @chapulina

osrf-migration commented 8 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


There are inconsistencies on other SDF elements too, such as axis. See issue #1828

osrf-migration commented 8 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Also for sensor

osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).