search

gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.2k stars 481 forks source link

ActorPlugin should accept bound limits as part of the parameters. #2962

Open fcolecumberri opened 3 years ago

fcolecumberri commented 3 years ago

The lines:

https://github.com/osrf/gazebo/blob/6595e68a5e913e82d4187b0e89d8ccc6ce660d37/plugins/ActorPlugin.cc#L200 https://github.com/osrf/gazebo/blob/6595e68a5e913e82d4187b0e89d8ccc6ce660d37/plugins/ActorPlugin.cc#L201 https://github.com/osrf/gazebo/blob/6595e68a5e913e82d4187b0e89d8ccc6ce660d37/plugins/ActorPlugin.cc#L202

Forces the actor to be inside the space of -3, -10 and 3.5, 2 ad forcing the Z pos value to be 1.2138.

These values should be variables received from the .world file since it is possible to create worlds a bigger than 6.5x12 or with more than one floor.

bach05 commented 3 years ago

I have fixed the problem, but it seems I can't open a pull request. If you want I can report in the comments the modification to the original code, they are a few.