Closed traversaro closed 1 year ago
This patch worked fine in https://github.com/conda-forge/gazebo-feedstock/pull/178 .
@traversaro, it seem you fix the windows issue. Are you going to merge it?
I wanted to rerun CI now that the citadel bottles of gazebo11 dependencies are fixed, and I noticed a minor whitespace issue, so I pushed https://github.com/gazebosim/gazebo-classic/pull/3331/commits/c4674eee1ad234d4a74bafc1d3ec401b595d3d63 to rerun CI
🎉 New feature
Fix compatibility with protobuf >= 22, similar to https://github.com/gazebosim/gz-msgs/pull/346 and other PRs linked there.
Summary
To minimize the risk of regression when protobuf < 22 is used, the protobuf version is obtained via pkg-config. If protobuf >= 22 is detected, then
find_package(Protobuf CONFIG REQUIRED)
is used andprotobuf::libprotobuf
andprotobuf::libprotobuf
are linked to make sure that the dependency with abseil is correctly handled.Test it
See conda-forge CI that now passes. Probably this PR can also be tested on homebrew that recently upgraded protobuf to 23.2, see https://github.com/Homebrew/homebrew-core/pull/132957 .
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.