gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.2k stars 484 forks source link

conda-forge: Pin libprotobuf to 3 until all the dependencies support protobuf >= 22 to fix Windows CI #3332

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

🦟 Bug fix

Summary

Workaround for https://github.com/gazebosim/gazebo-classic/pull/3330 . protobuf 22/23 brought many changes, so to fully support it we need to solve the following two issues:

Until then, to get the Windows build to work it is easier to just pin libprotobuf to 3 .

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

traversaro commented 1 year ago

@scpeters I think we should merge this to avoid that all other PRs have a failing Windows build, such as in https://github.com/gazebosim/gazebo-classic/pull/3309 .

traversaro commented 1 year ago

The proper fix is proposed in https://github.com/gazebosim/gazebo-classic/pull/3331, so I think we can close this workaround PR.