Closed lopsided98 closed 2 years ago
Thanks Ben for the pointers and the patch. Changes in code looks good to me, my testing a local wokrspace for packages up to gz-transport is fine and I run a testing build of the whole collection in for Windows (warnings and test are unrelated as far as I can tell).
Note that CMake 3.20 provides
cmake_path(APPEND)
which implements the same functionality asjoin_paths()
, but this CMake version is not available in all supported distros yet (notably Ubuntu older than 22.04).
I'm going to add a TODO not to forget about this.
🦟 Bug fix
The
CMAKE_INSTALL_*DIR
variables are allowed to be absolute paths, so they cannot be simply appended toCMAKE_INSTALL_PREFIX
. When an absolute path is needed,CMAKE_INSTALL_FULL_*DIR
must be used. See here for more information: https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-pathAdditionally, pkgconfig files should use
${prefix}
relative paths ifCMAKE_INSTALL_*DIR
are relative, but otherwise use absolute paths. This is handled by the customjoin_paths()
function.Note that CMake 3.20 provides
cmake_path(APPEND)
which implements the same functionality asjoin_paths()
, but this CMake version is not available in all supported distros yet (notably Ubuntu older than 22.04).Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.