Open Bi0T1N opened 11 months ago
LGTM! but I'll hold off merging so @j-rivero can take a look since he commented on #215.
To focus our efforts on the Ionic release, I'll go ahead and remove the beta
label from this. I don't think this is a breaking change, so we can merge it after Ionic.
🎉 New feature
Closes #215
Summary
This adds CMake macros to remove code duplication for creating pybind11 bindings.
The only problem that occurs is that it destroys the used structure in
CMakeLists.txt
(e.g. for gz-math):The other two macros are fine:
src/CMakeLists.txt
:Test it
/ws/install
mkdir build && cd build && cmake .. -DCMAKE_INSTALL_PREFIX=/ws/install/
make -j && make install
source /ws/install/setup.bash
, changeCMakeLists.txt
to usegz-cmake4
and the new macrosmkdir build && cd build && cmake .. && make -j
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸