gazebosim / gz-math

General purpose math library for robot applications.
https://gazebosim.org/libs/math
Apache License 2.0
55 stars 69 forks source link

Running Address Sanitizers on CI #370

Open chapulina opened 2 years ago

chapulina commented 2 years ago

There's currently some ongoing work to clean up ASAN warnings on Ignition Math. In order not to introduce regressions in the future, we should set up CI that runs ASAN periodically.

Desired behavior

ASAN is run periodically and its status is tracked by the build farmer.

Alternatives considered

People could keep running it manually...

Implementation suggestion

The current idea is to:

Most of the work should go into ign-cmake, and we may create a new GitHub action on https://github.com/ignition-tooling, similar to https://github.com/ignition-tooling/action-ignition-ci, or add a parameter to the existing action that enables ASAN.

Additional context

We considered using colcon's sanitizers like we have explained in our contribution guide, but decided for an ign-cmake native approach so this can be run without colcon.

j-rivero commented 2 years ago

ASAN builds are already running on our buildfarm https://build.osrfoundation.org/view/asan/. I'm waiting for the buildfarmer dashboard to include them https://github.com/osrf/buildfarmer/pull/304 but the task can consider done.

j-rivero commented 1 year ago

Blocked by https://github.com/gazebo-tooling/release-tools/issues/820