gazebosim / gz-math

General purpose math library for robot applications.
https://gazebosim.org/libs/math
Apache License 2.0
55 stars 69 forks source link

Helpers_TEST fails on arm64 debbuilds #485

Open scpeters opened 2 years ago

scpeters commented 2 years ago

Environment

Description

[ RUN      ] HelpersTest.AppendToStream
/home/jenkins/workspace/ign-math6-debbuilder/build/ignition-math-6.12.0/src/Helpers_TEST.cc:1012: Failure
Expected equality of these values:
  out.str()
    Which is: "0 456 0 3.14159 3.141592654 3.141592653589793238462643383279503"
  "0 456 0 3.14159 3.141592654 3.141592653589793239"
/home/jenkins/workspace/ign-math6-debbuilder/build/ignition-math-6.12.0/src/Helpers_TEST.cc:1022: Failure
Expected equality of these values:
  out.str()
    Which is: "0 456 0 3.14159 3.141592654 3.141592653589793238462643383279503 3.14"
  "0 456 0 3.14159 3.141592654 3.141592653589793239 3.14"
[  FAILED  ] HelpersTest.AppendToStream (0 ms)

Steps to reproduce

  1. Rebuild the following jobs

Output

j-rivero commented 2 years ago

This one is new to me. Somehow arm64 is rounding up the precision for PI while the other arches are not doing it. Not sure the severity of the issue since it is affecting what seems to an str method. If the problem of the lost of precision is affecting only string representation we could potentially ignore the error if the tests if we consider it superficial, if the problem is deep in the number real value then should be fixed.

j-rivero commented 2 years ago

Going to leave the issue open, see https://github.com/gazebosim/gz-math/pull/510#issuecomment-1256429468