gazebosim / gz-msgs

Messages for Gazebo robot simulation.
https://gazebosim.org
Apache License 2.0
24 stars 47 forks source link

Do not redefine GZ_PYTHON_INSTALL_PATH if it is already defined #393

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

🎉 New feature

Summary

When doing packaging, it is sometimes useful for advanced users to just tell the build system where to install Python files, without any sort of auto-detection. This was already supported elsewhere (see https://github.com/gazebosim/gz-msgs/blob/0472ba0bb5fe39d8a14499155c68746109d9acf7/core/CMakeLists.txt#L69 and https://github.com/gazebosim/gz-msgs/blob/gz-msgs10/cmake/gz_msgs_generate.cmake#L273) but was not supported at the root level.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 1 year ago

Codecov Report

Merging #393 (019129f) into gz-msgs10 (0472ba0) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 019129f differs from pull request most recent head e2cc2ab. Consider uploading reports for the commit e2cc2ab to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #393   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1170     1170           
==========================================
  Hits            1138     1138           
  Misses            32       32