search

gazlaws-dev / codeboard

Codeboard App
Other
554 stars 114 forks source link

Landscape View is broken! #71

Closed peterekepeter closed 4 years ago

peterekepeter commented 4 years ago

I've just started debugging the lastest master and I've noticed that landscape is completely broken, I get no keyboard at all.

commit 4aab2de0f04f3492972830dd6bfc15d777d3ee01
Date:   Fri May 1 12:45:12 2020 +0530

Also the separate landscape keyboard slider has been removed, was this on purpose or accident?

peterekepeter commented 4 years ago

@gazlaws-dev you have commented out the part which sets the landscape size, this means it stays on 0 forever and the landscape keyboard will have 0% height of the screen.

gazlaws-dev commented 4 years ago

Good catch! I had meant to make the landscape slider's upper/lower limit similar to how we cap the values in the portrait slider. But I never actually changed it, just commented it out. Will need to change this asap, thanks for reporting the issue.