search

gazorby / fifc

🐠 Configurable fzf completions for fish shell
MIT License
123 stars 7 forks source link

feat: use `$EDITOR` as default editor #17

Closed kidonng closed 1 year ago

kidonng commented 1 year ago

Alternative title: "respect $EDITOR environment variable"

By the way, I think all references to less should also consider $PAGER too, though that would be another (potential) pull request.

gazorby commented 1 year ago

Hi @kidonng, thanks for your comments!

Do you mean to set fifc_editor to $EDITORas default value? I'd prefer to not drop fifc_editor setting but rather use existing system configuration as default, if present.

kidonng commented 1 year ago

Right, this does not drop the config, just provides a sensible default.