search

gbdev / gb-asm-tutorial

Learn to create games for the Game Boy using Assembly
http://gbdev.io/gb-asm-tutorial/
MIT License
100 stars 31 forks source link

consistency and optimization improvement #87

Closed win-ini closed 2 months ago

win-ini commented 2 months ago

improving the code's consistency (it was very inconsistent before) and optimizing it

ISSOtm commented 2 months ago

Oh, thank you!

The consistency and style changes all seem straightforward to me.

The optimisation, though, I'm not sure, because I don't know if e.g. xor a has been explained (both what it does, why it does that, and why one should do it). I would reject such a change without question in Part II for readability reasons, but it makes sense to start dealing with that in Part III.

(I haven't fully reviewed the PR beyond that.)

win-ini commented 2 months ago

I've only changed p3, we can always add an explanation