search

gbdev / rgbds-live

A live Gameboy programming environment in the browser, allowing for realtime assembly programming for the gameboy.
https://gbdev.io/rgbds-live/
MIT License
37 stars 10 forks source link

Pick code style conventions #49

Open Rangi42 opened 1 week ago

Rangi42 commented 1 week ago

Since we manually edit the HTML, CSS, and JS here, we should decide on a preferred code style (indentation, line length, JS features to use/avoid, etc). The ones that can be enforced by Prettier should be added to .prettierrc, and other conventions should be documented in a STYLE.md file.

SelvinPL commented 1 week ago

"printWidth": 100, give it 150 per line - we are not living in middle ages with 1024x768 resolution also when i can back to work? with such changes you are not making it easy ...

Rangi42 commented 1 week ago

Sorry, I'm done now, that was the last of my broad auto-format changes. (I should really be focusing on work-work, lol.)

Can we compromise on 120? Screens/windows aren't always wide enough for 150. (I'm used to 100 from rgbds source.)

SelvinPL commented 1 week ago

120 fixes some strangly looking <a/>, fair enough could you do?

I'm thinking about about some small changes .. like menu and button size (I think they are too small padding: 4px 16px shoudl fix it also then menubar should be changed from 21 to 24xp)

So I would love if you would do 120 change and I would tweak those stuff

Rangi42 commented 1 week ago

Okay! I eventually want to do a broader UI reconsideration/refactor, but should not let myself get distracted by that right now, and if you end up accomplishing what's needed anyway, then great. :)