search

gbif / model-tests

Exploration of sample models
2 stars 0 forks source link

Missing agent identifiers #26

Open MortenHofft opened 2 years ago

MortenHofft commented 2 years ago

@tucotuco The data might not have been in the export, but if it is, then adding the agent identifiers could be a nice touch. https://arctos.database.museum/guid/DMNS:Mamm:11098 referes to https://arctos.database.museum/agent/796 which lists his ORCiD and more

tucotuco commented 2 years ago

The identifiers were indeed in the export from Arctos. They are in the file https://github.com/timrobertson100/model-tests/blob/master/arctos_v2/files/agent_identifier.csv. It looks like that file is included in both https://github.com/timrobertson100/model-tests/blob/master/arctos_v2/arctos_v2_create.sql#L12 and https://github.com/timrobertson100/model-tests/blob/master/arctos_v2/arctos_v2_constrain.sql#L39.

tucotuco commented 2 years ago

Ah, wait, I see. We have the table of identifiers, but it doesn't include the ORCiD.

tucotuco commented 2 years ago

The ORCIDs are in the export, but not where I would have expected them. I updated agent_identifiers.csv to include them and all the other identifiers I missed before in https://github.com/timrobertson100/model-tests/commit/1382ed15bae693d48db1e8e7db01f45db530577d.