search

gbowne1 / codebooker

This is a book recommendation app created with React 18.2 and MUI for coders/programmers looking for reccomendations to books on programming/coding to read
MIT License
31 stars 57 forks source link

Added new recommendations #178

Closed Karutoh closed 1 year ago

Karutoh commented 1 year ago

Added three books for recommendation. First, "Game Engine Architecture", second, "Digital Audio Theory: A Practical Guide" and finally, "Game Physics Cookbook".

BlackBond06 commented 1 year ago

@gbowne1, can't find this issue on the issues list.

gbowne1 commented 1 year ago

It's not in the issues list, @BlackBond06. This contribution is basically contributing to the intial database through the data.json file. I still have to add all of my books, and there's 300 of them.

As an aside, the data.json is broken. Most of the entries in the json are missing the "category" field, all but the first entry. Can we create a garbage collector utility to grab the data from the json and stuff it in the database? There is also no "id" or "_id" field. Yes I know we have the database, but there should be some other way that would work in case the database ever goes down, even a short term outage.

@Karutoh @BlackBond06 @LOGESH-B

BlackBond06 commented 1 year ago

@gbowne1, your request for an alternative way to fetch books if the database develops problem, is very sound and I support 100%.

gbowne1 commented 1 year ago

Yes, @BlackBond06

A non existent database, or an outage, unless it was a planned outage, would probably be rare, but it is an edge case I would like to solve and a pretty good feature to have a workaround for.

Karutoh commented 1 year ago

Yes, @BlackBond06

A non existent database, or an outage, unless it was a planned outage, would probably be rare, but it is an edge case I would like to solve and a pretty good feature to have a workaround for.

Instead of adding them manually. You could just have an option to cache them locally anytime you've connected with the database. Store a time stamp inside the file so you can determine when it was last updated and if it should be updated.

gbowne1 commented 1 year ago

Thats a great idea too.

gbowne1 commented 1 year ago

@LOGESH-B We should consider continuing to use it in the edge case if the database is missing, down for maintaining, problems with the database, or just offline in general.. we could probably figure out some way. I added the issue #179