Bug/hompage not displaying book from db - Githubissues

gbowne1 / codebooker

This is a book recommendation app created with React 18.2 and MUI for coders/programmers looking for reccomendations to books on programming/coding to read

MIT License

31 stars 57 forks source link

Bug/hompage not displaying book from db #194

Closed BlackBond06 closed 1 year ago

BlackBond06 commented 1 year ago

This PR resolves issue #193, which is Hompage not displaying books (if any) from db and loading spinner continuously running.

The changes made in this PR include improvements to the UI book population logic, which address various scenarios: -The loading spinner is now displayed while waiting for the database response.

In the event of database downtime, the UI is populated with books from data.json (This is where the PR from @KitaPDev would come in).
If there are books in the database, they are displayed.
Otherwise, the "Add Book" button is shown, along with a message indicating that the database is empty.

![Db](https://github.com/gbowne1/codebooker/assets/100074330/993037ba-ed8a-4fdb-89dc-3bafb1e0b507

LOGESH-B commented 1 year ago

Nowadays project takes long time to open on browser...is any one have this problem?

gbowne1 commented 1 year ago

@LOGESH-B @BlackBond06 we need to do some performance testing.

How long are your load times, @LOGESH-B ?

LOGESH-B commented 1 year ago

@LOGESH-B @BlackBond06 we need to do some performance testing.

How long are your load times, @LOGESH-B ?

4 min .I am not sure but it may be happend because of having only 5gb of free space in C drive on my syatem

gbowne1 commented 1 year ago

yeah that could be one thing causing load times at least in your case.

I have not noticed significant problems loading.

BlackBond06 commented 1 year ago

@LOGESH-B @BlackBond06 we need to do some performance testing. How long are your load times, @LOGESH-B ?

4 min .I am not sure but it may be happend because of having only 5gb of free space in C drive on my syatem

Mine doesnt take that long to load. Maybe, max 1min.

gbowne1 commented 1 year ago

Looks like there is a merge conflict with Library.jsx @BlackBond06

BlackBond06 commented 1 year ago

It was expected. The PR for seeding the UI with books from data.json addressed most of what this PR is working on, such as resolving the loading spinner continuously running and displaying the "add book" button when db is empty. I think this PR may not be necessary.

gbowne1 commented 1 year ago

@BlackBond06 I merged that other PR that dealt with this issue, but I have to be honest I don't know what to do about some of the issues that this represents.

There are some cases that I have described before that need to be handled effectively but I think lot of those issues have to wait until we are in production mode.

If you think we don't need this PR, there might be other things we can work with.

BlackBond06 commented 1 year ago

Yes, I think this PR is not necessary. The PR from @Priyankaa2503 has resolved everything this PR aims to resolve. Please clarify this statement: "If you think we don't need this PR, there might be other things we can work with"

gbowne1 commented 1 year ago

I am closing this PR.