gbrandt1 / southpole-vcvrack

Southpole Modules for VCV Rack
Other
67 stars 24 forks source link

0.5.3 - Tags #12

Closed DomiKamu closed 6 years ago

DomiKamu commented 6 years ago

Hi again,

IMO you'll must to review many tags you've used for your modules. Try to limit as possible UTILITY_TAG usage if you can. For example, for all blank panels, replace UTILITY_TAG by BLANK_TAG

Concerned modules:

Dominique Camus. Into attached .zip file: Southpole.cpp (edited) Southpole.zip

gbrandt1 commented 6 years ago

ah yes i have a bug in the slug names... i will fix that in the future. you can add it by hand for now, check the youtube video, it's configures as Two Drunks and RND1,RND2 are connected to Riemann P5/V and M3/V

DomiKamu commented 6 years ago

I don't have seen bug in SLUG names... I recommend to don't change them, because existing .vcv patch files will cause error when load (same for "internal" name listed just before menu title).

What platform are you using for development and compile?

When compiling on Win, they're a lot of "warnings", do you know about this?

nay-seven commented 6 years ago

i feel this answer was for me in another issue ;-)

gbrandt1 commented 6 years ago

ah yes not sure how that answer ended up here - don't github on the smartphone i guess...

Dominique your changes are implemented but will go in the next release

DomiKamu commented 6 years ago

It would be excellent about updated tags, of course for next release along Rack 0.6 (they'll few added, for 0.6, now listed into Rack/include/tags.hpp) @Nay of course you're right, but probably these warnings will disappear against 0.6, wait & see... I close this issue. Cheers!