search

gbrandt1 / southpole-vcvrack

Southpole Modules for VCV Rack
Other
67 stars 24 forks source link

Splash (two bumps) out of tune #24

Open martin-lueders opened 6 years ago

martin-lueders commented 6 years ago

Hi Gerhard,

something goes wrong in your calculation of the pitch in the "two bumps" mode. It is fine for samplerates of 48000 and 96000 but is out of tune for 44100 and 88200.

I have the impression that it was ok in older versions. I have a patch using the two bumps which worked fine in Rack 0.5. In 0.6, after renaming the module in my patch file (see other issue), it is out of tune.

Also, the patch now consumes MUCH more CPU and is basically unplayable. Not sure though which plugin is causing that...

Cheers, Martin

gbrandt1 commented 6 years ago

the API for samplerate calculations changed indeed, will check if i messed something up.

can't help with your patch since i have no idea what is in it, you'd have to send it to me for debugging.

gerhard

martin-lueders commented 6 years ago

Hi Gerhard,

dont worry too much about my patch. I guess many modules are currently not fully optimized.

I had a look at your code for the Splash Parasites, and noticed a few things which could be optimized more. For instance, the log2f you use in the ptich calculation is quite expensive. You dont need to call that for every buffer, but only if the sample rate has changed. You could replace it be a variable which you update only in the onSamplerateChange() function. and also call that function in your Constructor to make sure it is run when you start the module.

I am currently also going through my own plugins to try to optimize them better.

Cheers, Martin