search

gbv / Catmandu-PICA

Catmandu modules for working with PICA+ data
https://metacpan.org/release/Catmandu-PICA
Other
4 stars 4 forks source link

Tests have started to fail for 1.09 after release of PICA-Data 2.06 #79

Closed andk closed 1 year ago

andk commented 1 year ago

Sample fail report: http://www.cpantesters.org/cpan/report/8a6fde46-a772-11ed-ac40-0d1af2d2463d

Statistical analysis on my smokers hints that PICA::Data 2.06 is likely blame candidate:

****************************************************************
Regression 'mod:PICA::Data'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    48942084208964240.00
[1='eq_2.04']         0.0000          0.0000       5.16
[2='eq_2.05']         0.0000          0.0000       5.19
[3='eq_2.06']        -1.0000          0.0000    -22338902943805908.00

R^2= 1.000, N= 63, K= 4
****************************************************************
nichtich commented 1 year ago

This stems from introduction of PICA::Data::Field in PICA-Data 2.06. Before that a field was just an array reference, now it is a blessed array reference. Normal array access is still possible but it looks like Catmandu Fix language cannot handle this. The reason seems to be in calling is_array_ref in emit_get_key using is_array_ref. This should be something like is_array_ref_blessed_or_not. I published a hotfix release but some fix scripts may produce incomplete results unless this is fixed in Catmandu core.

nichtich commented 1 year ago

Fixed in 1.11