gcarq / inox-patchset

Inox patchset tries to provide a minimal Chromium based browser with focus on privacy by disabling data transmission to Google.
BSD 2-Clause "Simplified" License
364 stars 26 forks source link

inox compilation with musl libc #55

Closed Kokokokoka closed 7 years ago

Kokokokoka commented 7 years ago

Hello, I was trying to get inox patchset working on musl (http://git.alpinelinux.org/cgit/aports/tree/community/chromium?h=master), the thing is that on musl the shim allocator is replaced with none, and it still tries to compile it with name unifiedshim allocator, I would love to get inox patchset working, could you be of assistance?

gcarq commented 7 years ago

AFAIK chromium doesn't support musl out of the box, but the alpine team crafted some patches to do so. There was a thread on a mailing list some times ago (link to patches is included): http://www.openwall.com/lists/musl/2016/03/18/20

Kokokokoka commented 7 years ago

Yes, I even linked those patches, but still, chromium tries to compile shim, on the second compilation step, It tries to build unified shim, maybe I could fix this issue, but I don't know where to look, as it is not the tools/gn/bootstrap/bootstrap.py
in the gn patch: -'base/allocator/allocator_shim.cc', -'base/allocator/allocator_shim_default_dispatch_to_glibc.cc', and the first stage went flawlessly, it's the second step, I would like to find out where was the second step declared if not in the bootstrap.py

gcarq commented 7 years ago

On which distribution are you building this? You can look at the chromium APKBUILD file from alpine linux, they are using some interesting build flags including:

-Duse_allocator=none
-Duse_experimental_allocator_shim=false
Kokokokoka commented 7 years ago

On exherbo it's a gentoo spinoff, with paludis and eclectic. I'll take a look. I think that was the thing that I've missed. Oh, I've found where were the compilation flags, thank you!

gcarq commented 7 years ago

you're welcome