search

gcarq / rusty-blockparser

Bitcoin Blockchain Parser written in Rust language
GNU General Public License v3.0
370 stars 145 forks source link

Incorrect block height value if using --start option #68

Closed 951356c0e770968a4edd45deade209a5 closed 1 year ago

951356c0e770968a4edd45deade209a5 commented 3 years ago

Hi! Thank you for work on this program, its cool. I found bug: in csvdump mode block height cell calculated as count processed blocks and ignoring --start option. Other block information correct,

Two first lines from file blocks-0-300000.csv: 000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f;0;1;285;0000000000000000000000000000000000000000000000000000000000000000;4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b;1231006505;486604799;2083236893 00000000839a8e6886ab5951d76f411475428afc90947ee320161bbf18eb6048;1;1;215;000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f;0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098;1231469665;486604799;2573394689

Two first lines from file blocks-300000-400000.csv: 000000000000000082ccf8f1557c5d40b21edabb18d2d691cfbf87118bac7254;0;2;128810;000000000000000067ecc744b5ae34eebbde14d21ca4db51652e4d67e155f07e;915c887a2d9ec3f566a648bedcf4ed30d0988e22268cfe43ab5b0cf8638999d3;1399703554;419465580;222771801 000000000000000049a0914d83df36982c77ac1f65ade6a52bdced2ce312aba9;1;2;241334;000000000000000082ccf8f1557c5d40b21edabb18d2d691cfbf87118bac7254;7cbbf3148fe2407123ae248c2de7428fa067066baee245159bf4a37c37aa0aab;1399704683;419465580;3476871405

Version column (2nd) in file with blocks started from 300000 start counting from 0.

gcarq commented 1 year ago

This should be fixed with 0.9.0