gdcc / dataverse-ansible

Ansible role for installing Dataverse
GNU General Public License v3.0
18 stars 21 forks source link

switch to a glob to support payara 5, 6, etc. #307

Closed pdurbin closed 1 year ago

pdurbin commented 1 year ago
donsizemore commented 1 year ago

I think the more robust way would be to make a jinja template from this script, and use {{ payara.dir }} as the target directory.

Correct, but in this case the script launches Ansible. Would we ever have two Payara versions on an Ansible-managed installation?

pdurbin commented 1 year ago

in this case the script launches Ansible

... and it literally creates the ec2 instance, hence the name ec2-create-instance.sh

That instance should only have one version of Payara, the version we just installed.