Fix Config Flow Issues - Githubissues

gdgib / span

SPAN Integration for HomeAssistant/HACS

Other

20 stars 4 forks source link

Fix Config Flow Issues #12

Closed etmelvin closed 1 year ago

etmelvin commented 1 year ago

Fixes gdgib/span#9

Added the ability to provide your own access token instead of using proximity authentication
Fixed an issue where config flow fails on user step when reauth is needed
Fixed an issue where Home Assistant will discovery the same panel
Fixed an issue where auth flow on discovery fails on missing access token

jeffkibuule commented 1 year ago

@gdgib Any chance we could get this merged soon? Would love to test it out.

gdgib commented 1 year ago

Thanks for asking @jeffkibuule I apparently had a small email gap in github notifications there. Didn't even see this until you asked.

Even bigger thanks to @etmelvin. Nice work!

gdgib commented 1 year ago

@jeffkibuule let me know when you've tested this. I kinda want to hold off on a release until one of us does, and I won't have time to test before the weekend.

gdgib commented 1 year ago

Hey @etmelvin nice work on this. It's holding up very well so far in testing, and I appreciate the quality of the code.

jeffkibuule commented 1 year ago

Hmm, I'm glad I waited. While I don't have the authentication errors I usually get with HomeAssistant warning me, after a few days, each entity is listed as unavailable at about the same cadence as it previously told me Span wasn't working at all. :(

etmelvin commented 1 year ago

Is there a stack trace or some error logs you can provide?

gdgib commented 1 year ago

Also.... how many days (roughly) are we talking about here?

jeffkibuule commented 1 year ago

False alarm, it's been pretty durable for the last 2 weeks. Glad it got merged. Thank you!