search

gdgib / span

SPAN Integration for HomeAssistant/HACS
Other
20 stars 4 forks source link

Addresses issue #25, Once the AuthKey flow is starting in config, it can't be backed out #47

Closed cayossarian closed 8 months ago

cayossarian commented 8 months ago

Addresses Issue #25 by changing the config flow auth token field to be optional and checking for an empty string. Using the 'X' dialog abort in the upper right only closes the dialog back to the same step.

Unfortunately we can't go back to the previous step using the dialog abort as with other dialogs because the user_input does not allow us to differentiate between the menu that initiated this manual auth step and an abort as in both cases user_input is None.

The same issue of not being able to use dialog abort/'x' will arise with proximity auth step, only worse as there is no way to exit that dialog since no user entered data is involved.

gdgib commented 8 months ago

Hey @cayossarian would you mind merging gdgib:main back into your branch so I can get a clean diff on this one, when you have a second? No problem if you don't get to it, I'm just having some transient networking issues with github right now, or I'd review locally.

cayossarian commented 8 months ago

Hey @cayossarian would you mind merging gdgib:main back into your branch so I can get a clean diff on this one, when you have a second? No problem if you don't get to it, I'm just having some transient networking issues with github right now, or I'd review locally.

Sure, @gdgib I've merged your main back into my pull request branch so you can isolate these changes. The only remaining change after this pull request, if you choose to take it, is the solar inverter enhancement. Let me know if you want a pull request for that.

gdgib commented 8 months ago

Please, when you have a minute.