search

gdquest-demos / godot-3-demos

Dozens of free and open source demos for the Godot game engine, version 3. Head to the link below for newer demos for Godot 4+
https://github.com/gdquest-demos/
MIT License
1.85k stars 978 forks source link

Fix healing typo to correct behavior #72

Closed WolfgangSenff closed 3 years ago

WolfgangSenff commented 3 years ago

Please check if the PR fulfills these requirements:

Related issue (if applicable): #

What kind of change does this PR introduce? Just a slight typo fix.

Does this PR introduce a breaking change? I wouldn't call it that.

New feature or change

Fixes #71.

What is the current behavior? When you heal, it automatically heals you the full amount, regardless of how much you've healed or how high your hit points are. Further, if you heal beyond the max health, it remains at the higher value instead of being reduced to the max health allowed.

What is the new behavior? Correcting the above by making it only be able to go up to the max health, and when healing, it selects the current health if it's still below the max health after healing because the healed amount doesn't bring up to the max health.

Other information

WolfgangSenff commented 3 years ago

I didn't see anything in the documentation that required updating for this change; if there is something specific, let me know, happy to make that update as well and add it here.

NathanLovato commented 3 years ago

For small fixes like those, you don't have to write the whole template. A short sentence explaining the issue is good. Thanks much for the PR.