search

gdsfactory / gplugins

gdsfactory plugins
https://gdsfactory.github.io/gplugins/
MIT License
37 stars 30 forks source link

`extend_ports` is defined but not actually used in `Tidy3DComponent` #452

Closed tomflexcompute closed 3 months ago

tomflexcompute commented 3 months ago

In Tidy3DComponent, extend_ports is defined but not actually used anywhere. Therefore there is no way to effectively set the extension length for ports.

joamatab commented 3 months ago

@yaugenst

yaugenst commented 3 months ago

Hey @tomflexcompute, it's a field of the LayeredComponentBase, from which the Tidy3DComponent inherits, see here. It is used to extend the ports of the gds component and set bounding boxes accordingly. Is there something in particular that you think isn't working?

tomflexcompute commented 3 months ago

Hey @tomflexcompute, it's a field of the LayeredComponentBase, from which the Tidy3DComponent inherits, see here. It is used to extend the ports of the gds component and set bounding boxes accordingly. Is there something in particular that you think isn't working?

Good to see you on the other side @yaugenst :grin:. Some user reported this parameter has no effect. Let me double check.

tomflexcompute commented 3 months ago

Ok the user confirmed that it's working properly even though he encountered some issues that he couldn't reproduce now. If he encounters the issue again we can look into it.

yaugenst commented 3 months ago

Great!