search

gdsfactory / gplugins

gdsfactory plugins
https://gdsfactory.github.io/gplugins/
MIT License
37 stars 30 forks source link

Update meep_adjoint_optimization.py. component.copy() to component.dup() #475

Closed kdotom closed 3 months ago

kdotom commented 3 months ago

updating component.copy() to component.dup() to address warning: "UserWarning: copy() is deprecated and will be removed in gdsfactory9. Please use dup() instead."

sourcery-ai[bot] commented 3 months ago

🧙 Sourcery has finished reviewing your pull request!

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
kdotom commented 3 months ago

@joamatab Hey, this is a simple one-line change, but I think the full suite of automatic checks fails for a few unrelated tests (with Sourcery AI). If there's anything specific I'd need to do to make the automated review process smoother for changes like these (or if there's actually an issue with the PR), definitely let me know. Thanks!