search

gearman / gearmand

http://gearman.org/
Other
740 stars 137 forks source link

Renamed HACKING to Contributing.md and updated; added CODE_OF_CONDUCT.md #325

Closed KanishkKhurana closed 3 years ago

esabol commented 3 years ago

@KanishkKhurana : I'm not sure the first 21 or 22 lines of CONTRIBUTING.md have any long-term usefulness to the project beyond Hacktoberfest. Please delete.

esabol commented 3 years ago

Also, the bulk of the text in CONTRIBUTING.md needs to be converted to Markdown.

KanishkKhurana commented 3 years ago

@esabol yes , i'll do this asap

KanishkKhurana commented 3 years ago

@esabol i have added markdown elements to the file. please let me know if there are any other changes. though i have only been coding for a few months , i get to learn a lot through these simple tasks and thus enjoy it !

esabol commented 3 years ago

Much better, @KanishkKhurana , but I think more Markdown changes need to be made to CONTRIBUTING.md.

If you look at how the file is rendered on GitHub, you see that some lines are word-wrapped that shouldn't be, like the if/then/else block, etc.

Check it out here:

https://github.com/gearman/gearmand/blob/e5784d8d6f29ee3ca92fd5c40f2ff4d220962298/CONTRIBUTING.md

KanishkKhurana commented 3 years ago

@esabol Please review the changes and do let me know if it needs more edits

KanishkKhurana commented 3 years ago

@esabol , i have made all the changes you have requested . please review them, sorry it took a while . i request you to please add hacktoberfest and hacktoberfest-accepted labels to this PR as it will really help me .

KanishkKhurana commented 3 years ago

all the changes have been done @esabol , please review :)

esabol commented 3 years ago

This looks perfect, @KanishkKhurana. I'll get this merged as soon as an issue with Travis CI is rectified.

KanishkKhurana commented 3 years ago

@esabol thank you so much ! It was really fun working on this and thank you for teaching me how to properly write in a markdown file !

esabol commented 3 years ago

@KanishkKhurana: We were able to resolve our Travis CI issues with this repo. Now, you need to rebase your pull request in order to bring in the changes to the CI setup. Are you familiar with the steps for rebasing a PR? Let me know if you need some guidance on how to do that. Personally, I prefer the method described here.

esabol commented 3 years ago

@KanishkKhurana: We were able to resolve our Travis CI issues with this repo. Now, you need to rebase your pull request in order to bring in the changes to the CI setup. Are you familiar with the steps for rebasing a PR? Let me know if you need some guidance on how to do that. Personally, I prefer the method described here.

Never mind! You don't need to do that. I was thinking of how GitLab CI/CD works. Just restarting the Travis CI jobs that failed before has worked, so I can merge your PR now.

Thanks, @KanishkKhurana !

KanishkKhurana commented 3 years ago

i had started reading the link you had given @esabol but looks like i got lucky . thank you !