search

gearman / gearmand

http://gearman.org/
Other
740 stars 137 forks source link

Confusing: --show-unique-jobs explainer in gearadmin --help #335

Closed octavn closed 2 years ago

octavn commented 2 years ago

From the gearadmin --help output one might get the impression that gearman does not deduplicate jobs and that it holds internally a number of jobs that could be greater than the number of unique jobs (all-duplicate=unique):

  --show-unique-jobs             Show unique jobs on server.
  --show-jobs                    Show all jobs on the server.

The gearadmin --show-unique-jobs command collects the unique jobs information from the show unique jobs command available in the gearmand TEXT protocol which "List all of the unique job ids that the server currently is processesing or waiting to process.".

To avoid/remove the confusion, the above one liner explanation for --show-unique-jobs should be changed to "Show the unique ids for the jobs on the server" in https://github.com/gearman/gearmand/blob/master/bin/gearadmin.cc#L142.

esabol commented 2 years ago

I concur and have submitted PR #336 to address this issue.

esabol commented 2 years ago

Fix merged. Closing.