search

gedcom7code / c-converter

Converts GEDCOM 5.5.1 to GEDCOM 7
The Unlicense
3 stars 2 forks source link

"ADOP Y" is handled incorrectly #4

Closed dthaler closed 3 years ago

dthaler commented 3 years ago

It appears to be incorrectly treating g7:ADOP as g7:FAMC-ADOP and generating illegal GEDCOM 7 output, since "OTHER" is not a legal value of g7:ADOP.

Input:

1 ADOP Y

Output:

1 ADOP OTHER
2 PHRASE Y
tychonievich commented 3 years ago

I cannot replicate this bug.

Input:

0 HEAD
1 CHAR UTF-8
1 GEDC
2 VERS 5.5.1
2 FORM LINEAGE_LINKED
0 @1@ INDI
1 ADOP Y
1 FAMC @2@
2 ADOP BOTH
0 TRLR

Output:

0 HEAD
1 GEDC
2 VERS 7.0
0 @1@ INDI
1 ADOP Y
1 FAMC @2@
2 ADOP BOTH
0 TRLR

Can you provide more context?

dthaler commented 3 years ago

The input you show does give me the output you show, but try this.

Input:

0 HEAD
1 CHAR UTF-8
1 GEDC
2 VERS 5.5.1
2 FORM LINEAGE-LINKED
0 @1@ INDI
1 BIRT
2 FAMC @2@
1 ADOP Y
1 FAMC @2@
0 @2@ FAM
1 CHIL @1@
0 TRLR

Output:

0 HEAD
1 GEDC
2 VERS 7.0
0 @1@ INDI
1 BIRT
2 FAMC @2@
1 ADOP OTHER
2 PHRASE Y
1 FAMC @2@
0 @2@ FAM
1 CHIL @1@
0 TRLR
tychonievich commented 3 years ago

Fixed; output is now

0 HEAD
1 GEDC
2 VERS 7.0
0 @1@ INDI
1 BIRT
2 FAMC @2@
1 ADOP Y
1 FAMC @2@
0 @2@ FAM
1 CHIL @1@
0 TRLR