search

geddski / csstyle

MOVED TO https://github.com/csstyle/csstyle a modern approach for crafting beautifully maintainable stylesheets
http://csstyle.io
Other
851 stars 34 forks source link

More options for SASS #36

Closed CupOfTea696 closed 9 years ago

CupOfTea696 commented 9 years ago

Makes all the styles configurable.

geddski commented 9 years ago

thanks @CupOfTea696! This will be a great improvement. Could you check why the tests are failing? npm run test Thanks!

geddski commented 9 years ago

@CupOfTea696 nevermind they're passing now, must have been on the wrong branch. I'll review this shortly.

CupOfTea696 commented 9 years ago

Maybe it was an earlier bug? Because I've noticed and fixed a few after I made the pull request. Either way, you're welcome :)

geddski commented 9 years ago

@CupOfTea696 landed in 1.3.2. I squashed the commits down to a single commit. Thanks for all your hard work!

geddski commented 9 years ago

P.S. I love the forward slash for parts. Considering making that the default. What do you think?

geddski commented 9 years ago

FYI I just added this same behavior to the postcss version.

CupOfTea696 commented 9 years ago

You're more than welcome! I absolutely love using CSStyle :)

Yeah, the forward slash really give me a feel of OOP, or at least OOP in PHP. However, I do think changing the default might result in some people updating csstyle in current projects and then having to change all of their html, so that's something to be considered.

Also, I noticed that my latest commits haven't been included yet, those ones that automate the character escaping, so you don't have to include escape characters in the setting vars anymore.