search

geddy / model

Datastore-agnostic ORM in JavaScript
265 stars 55 forks source link

rename ModelBase.type to ModelBase._type and use ModelBase.getType() #88

Open der-On opened 11 years ago

der-On commented 11 years ago

The reason behind this is, that I constantly define the property "type" on models. But I always forget that "type" is a reserved "property".

ben-ng commented 11 years ago

I'm not sure if this is a good idea as it's a breaking change for marginal benefit. For example, I personally depend on the type property as I have models that inherit from a parent model.

The new Responder in geddy master also depends on the type property to generate the template context.

I'm curious as to what @mde thinks.