geeksforsocialchange / PlaceCal

Bring your community together
https://placecal.org
GNU Affero General Public License v3.0
17 stars 8 forks source link

create a component for partnership instances #1845

Closed aaaaargZombies closed 1 year ago

aaaaargZombies commented 1 year ago

acceptance criteria

Prerequisites

implementation plan

The top row of items "visit a partnership"

image

kimadactyl commented 1 year ago

I think we were going with the bottom row thing not the top one!

this also shows up on the new homepage i think

just a small note on the prereqs that we only need a design or a wireframe - not both. ideally former, latter also fine but the latter is a step to the former.

i think the criteria should be clearer too - one criteria per component. so if the grid is one and the individual item is one and the title is one, that 3 components for ex. We can then use this to more clearly signal where we are going to do some reuse (for example, @aaaaargZombies grid should be reusable for this)

kimadactyl commented 1 year ago

ah - also confused as this ticket talks about both partners and partnerships and the screenshot has neighbourhoods in it - which is it?

kimadactyl commented 1 year ago

one last final issue - the screenshot and wireframe links are different. delete one of them or make clear why theyre both linked?

ivan-kocienski-gfsc commented 1 year ago

I see @katjam has closed the parent issue - does this mean this issue should be expanded to cover the set of 4 partnerships and not just the individual partnership component?

ivan-kocienski-gfsc commented 1 year ago

Progress:

Screenshot_20230511_150056

ivan-kocienski-gfsc commented 1 year ago

More progress:

Screenshot_20230511_164702

r-ferrier commented 1 year ago

Final implementation:

Screenshot 2023-05-22 at 12 55 19

Screenshot 2023-05-22 at 12 55 10

Screenshot 2023-05-22 at 12 55 26