Closed r-ferrier closed 1 year ago
i think they deffo need control over is_published
deffo don't let them edit slug
(and in geneal i think only let roots edit slugs)
i can see the case for badge_zoom_level
too but also see the case for not
theme
is a weird one as if we make them logos in one colour and they change it itll obviously look bad but maybe thats their problem
otherwise looks good :)
just to note i think they need to be able to view all the fields tho still - maybe this could be in a little info pane? or maybe just a disabled field either good
badge_zoom_level
relates to the lozenge in the public UI ie, manchester or hulme
The admin UI could be clearer.
broken site_admin ui
also tags
should be renamed partnerships
weird behavior, if a root adds another neighbourhood to the site
but the user is not a neighbourhood_admin for that neighbourhood it shows up incorrectly - presumably because they aren't allowed to see it.
I guess this is the responsibility of the Root to not create a site where the admin is not neighbourhood_admin for the areas it encompasses
I have captured this as an issue here #2115
Good catch - yeah at the moment this is 2 steps you have to do manually and one day it would be good to remove it but for now we are doing this rarely and always by a gfsc team member?
Verified:
(all visible in both below screenshots)
everything editable as neighbourhood admin except other neighbourhoods, partnerships, domain, site_admin_id, slug, main neighbourhood
everything editable as a root except main neighbourhood
Needs verifying/ need to check there isn't anything you can change you shouldn't be able to change
desired permissions / AC
Attribute
Root
site_admin
verified/ticketed
badge_zoom_level
✅
✅
✅
description
✅
✅
✅
footer_logo
✅
✅
✅
hero_image_credit
✅
✅
✅
hero_image
✅
✅
✅
hero_text
✅
✅
✅
logo
✅
✅
✅
name
✅
✅
✅
place_name
✅
✅
✅
tagline
✅
✅
✅
theme
✅
✅
✅
is_published
✅
✅
✅
"other neighbourhoods"
✅
❌
✅
"tags" -> "partnerships"
✅
❌
✅
domain
✅
❌
✅
site_admin_id
✅
❌
✅
slug
✅
❌
✅
"main neighbourhood"
❌
❌
✅
Note that main neighbourhood is not editable as this was causing issues in the past and it seemed easier to delete and remake. It may be this is no longer an issue.