Unique link text

[ivan-kocienski-gfsc]

Fixes #319

Description

Have put in the changed link text for project "visit site" link

@geeksforsocialchange/developers

[cloudflare-workers-and-pages[bot]]

Deploying with    Cloudflare Pages

Latest commit:	edc5eaa
Status:	✅  Deploy successful!
Preview URL:	https://8692d555.gfsc.pages.dev
Branch Preview URL:	https://ik-319-unique-link-text.gfsc.pages.dev

View logs

[aaaaargZombies]

I see that kim has suggested to add aria-label to avoid having lots of differently sized buttons but the original issue is about project pages find out more not being informative enough. This isn't really an issue with screenreaders, you should be able to tell where your going if you see a link. This came up from the starling checklist we use.

We give links descriptive names, so you know exactly what they’re about. You won’t find any ‘click heres’ in these parts.

Example in the issue would be to switch to something project specific find out more -> visit whitepube site or similar.

This would be a good thing to speak to @honor-gfsc / @rebeccawigmore about, what is useful text to have there and how can we let them customise that when they are updating a project.

[r-ferrier]

sorry, reading back I'm not sure I made that very clear - I think the project index change is good, just needs the span class removing, and maybe as @aaaaargZombies says, get some feedback from content team, and revert the other changes to repeat buttons in lists

[r-ferrier]

From a code perspective this looks much better, but I'm really not sure about the content - it just doesn't always make sense to say this for every project. eg Visit The White Pube Website Overhaul site makes no sense and Visit Hulme Community Garden Centre website consultancy site just takes you to a trello board of user stories.

I'm sorry I didn't properly look at all use cases for this before the last review, I assumed because you'd taken this approach the buttons were all taking you to a linked site and the projects were all named after said sites. I think probably best for now to close this and have a rethink with the content team if we want to address this in the future because it probably needs more project specific wording, as @aaaaargZombies says above?

[ivan-kocienski-gfsc]

Closing this as the AC could be better defined.

What we need to do is to go through the site looking at all the places where links/buttons have repetitive texts and make a case-by-case decision on how that text can be extended into sentences that make grammatical sense. This may involve either changing the content (i.e. the title of a project) or it may involve putting in a new field in the markdown that can have the specific text.