geerlingguy / airgradient-prometheus

AirGradient Prometheus exporter.
MIT License
176 stars 59 forks source link

screen might be flipped when it should not be? #15

Closed Thelvaen closed 2 years ago

Thelvaen commented 2 years ago

considering the design of the case in the STLs provided by airgradient, it seems that the screw mounts are not in an orientation that would allow the screen to be read properly (it ends up on the top left instead of the bottom right corner.

Can I PR the following code:

// AirGradient case has its screws behind the screen with the fixation reverse compared
// to Jeff G. box, so flipping the screen is not necessary
// uncomment if you need/prefer having the screen on the bottom.
//#define flipScreen

and

  #ifdef flipScreen
  display.flipScreenVertically();
  #endif
geerlingguy commented 2 years ago

Yes; though I'd suggest for the description near the top where the variable is:

// Uncomment to flip the display 180 degrees.

No need for further explanation, I may consider changing the default in the future, though, if the case design is now inverted from what it was earlier last year.

Thelvaen commented 2 years ago

I believe it's no longer the same case, as you can see on that capture of my slicer screen the mounting screw holes make it pretty obvious that the fan on the PM2.5 sensor needs to be on the bottom, hence needing to flip the screen.

mounting_screw

That being said, it does not really make sense for the USB connector, because now it ends up on the top, and that's not good, I might sacrifice a USB cable to solder the 5V/GND directly to the board, but that's an other topic.

stale[bot] commented 2 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 2 years ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.