search

geheur / weapon-animation-replacer

BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Scythe swing doesn't trigger if there is no attack animation override. #24

Closed GrimWrath closed 1 year ago

GrimWrath commented 2 years ago

When attempting to use the effect SCYTHE_SWING and changing the color, nothing is produced, no default nor changed animation. OpenOSRS_kZnfD63bTX OpenOSRS_yzW9eSqrgZ

geheur commented 2 years ago

What weapon are you using (the real one, not the transmog). The plugin uses a list of animations to determine when you are attacking so that it can make the scythe swing trail. If you're using a weapon with unique animations that I haven't added, that would explain this.

GrimWrath commented 2 years ago

I tried using my own sanguine scythe as well as my bare fists.

geheur commented 2 years ago

Ah I see, this is a bug. If you don't override the attack animation it misses the code path that triggers the swing trail. So as a temporary fix you could add the scythe (or any other animation set) animations override.

Also fwiw the plugin currently does not remove the existing scythe's swing trail. I don't have a scythe so this got overlooked ;) So if you are using this with your real scythe it may not work as expected.

GrimWrath commented 2 years ago

I see - thank you. feel free to reach out to me ingame at Grim Fervor and I could help you out with ids and things you may need for those out of reach weapons/armor :)

GrimWrath commented 2 years ago

It seems I'm having the same issue following your instructions. Are you able to reproduce a change in scythe swing color? image

geheur commented 2 years ago

For anyone else reading this, this issue (as well as pose animation overrides probably not working) can also be caused by not using runelite. But I think that will be fixed soon.

geheur commented 1 year ago

I fixed this a while ago, and openosrs no longer exists afaik. so either way this issue is fixed.