geiger-rs / cargo-geiger

Detects usage of unsafe Rust in a Rust crate and its dependencies.
https://crates.io/crates/cargo-geiger
1.41k stars 66 forks source link

[bug] `cargo-geiger` fails/errors out when `Cargo.toml` has nightly features #181

Open Evrey opened 3 years ago

Evrey commented 3 years ago

To be precise, my Cargo.toml has cargo-features = ["strip"] to strip the symbol table in release builds. The TOML parser in cargo-geiger rejects this, assuming all Cargo.tomls to be stable only.

Here are my suggestions on how to solve this problem:

anderejd commented 3 years ago

For this specific problem, it's possible that this will be solved by upgrading our old cargo crate dependency (in progress).

I know next to nothing about nightly Rust since I don't use it due to its experimental and unstable nature, but if someone wants to add support for and maintain support for nightly that would be most welcome. To be clear, I don't have any philosophical problem with nightly Rust, it's a matter of resources (time).

anderejd commented 3 years ago

Upgrading cargo is in the works as part of #183.

jullanggit commented 1 month ago

Same issue here with the unstable.gc and unstable.gitoxide fields.